Improve the AMP link protection test page #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected some expected URLs (e.g. added missing trailing '/'s). - Replaced ampersands in expected URLs with the proper character entity, so that they are handled correctly. - Simplified the ampproject.org example so that it doesn't contain parameters which will be stripped by tracking parameter protection and so that it doesn't contain a fragment part in the middle of the query parameters (which is invalid). - Added a note that some of the test cases will be redirected successfully on desktop, even without AMP protection enabled. - Removed some trailing whitespace.
12 tasks
SlayterDev
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those.
entity, so that they are handled correctly.
parameters which will be stripped by tracking parameter protection and
so that it doesn't contain a fragment part in the middle of the
query parameters (which is invalid).
successfully on desktop, even without AMP protection enabled.