Element hiding test page #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Jan 23, 2023
|
@kdzwinel thanks for the review! Just pushed a commit to address your comments. |
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test page for the element hiding feature. I've set it up so that it will work if it is served on either the
first-party.siteorprivacy-test-pages.glitch.medomains (see relevant rules in privacy config here).To run locally (on macOS) I had to add entries to my
/etc/hostsfile pointinggood.third-party.site&www.first-party.site->127.0.0.1, and then followed the mkcert instructions from the README, but withthird-party.site "*.third-party.site"&first-party.site "*.first-party.site"appended to the command--this actually producedfirst-party.example+13-key.pmandfirst-party.example+13-key.pmfiles, which weren't picked up by express without editing these lines to match. @kdzwinel should I update these and the README docs to match?The page tests several cases for each rule type and outputs the results to a table as well as a
resultsglobal variable.cc @jonathanKingston