Add a test page for cosmetic autoconsent rules #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Jan 24, 2023
features/autoconsent/banner.html
Outdated
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <title>Autoconsent Cosmetic Test</title> |
There was a problem hiding this comment.
This should be in line with how we call it on the index page so "Cookie consent popup test".
index.html
Outdated
Comment on lines
43
to
44
| <li><a href="./features/autoconsent/">Cookie consent</a></li> | ||
| <li><a href="./features/autoconsent/banner.html">Cookie consent banners</a></li> |
There was a problem hiding this comment.
Hm, I wonder if we should rename previous one to be sth like "Cookie consent popups" and this one to be "Cookie consent banners" or notifications?
features/autoconsent/banner.js
Outdated
| }, 500); | ||
|
|
||
| window.results = { | ||
| page: 'autoconsent', |
There was a problem hiding this comment.
let's use unique id's for pages, this one can be 'autoconsent-banner'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.