Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrer Trimming test page #14

Merged
merged 13 commits into from
Dec 14, 2020
Merged

Conversation

Copy link
Member Author

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Charlie-belmer LMK what you think!

// list of localStorage entries with partial test results that we need to clear at the end of all testing
const lsEntriesToClear = [];

function generateNavigationTest(url) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are very similar with only URL being different (1p, 3p, tracker), so I extracted their generation into functions.

}
}

function generateFrameTest(url) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Collaborator

@Charlie-belmer Charlie-belmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@kdzwinel kdzwinel merged commit 608d750 into duckduckgo:gh-pages Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants