Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore scripts on install, move C-S-S to be a build dep #150

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Ignore scripts on install, move C-S-S to be a build dep #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm ci --ignore-scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also change it in https://github.com/duckduckgo/privacy-test-pages/blob/main/git.sh ? Should git.sh call this workflow instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup done: 2bba811 :)

- run: npm run build --if-present
- run: npm test
34 changes: 19 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
},
"homepage": "https://github.com/duckduckgo/privacy-test-pages#readme",
"dependencies": {
"@duckduckgo/content-scope-scripts": "github:duckduckgo/content-scope-scripts#4.11.1",
"body-parser": "^1.20.2",
"express": "^4.18.2",
"node-cache": "^5.1.2",
"node-cmd": "^5.0.0",
"ws": "^8.13.0"
},
"devDependencies": {
"@duckduckgo/content-scope-scripts": "github:duckduckgo/content-scope-scripts#4.10.1",
"eslint": "^7.32.0",
"eslint-config-standard": "^16.0.3",
"eslint-plugin-html": "^7.1.0",
Expand Down