Add support for ad cookie checking #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
Merged
12 tasks
sammacbeth
approved these changes
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 27, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 28, 2023
jonathanKingston
added a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
Apr 28, 2023
* Validate that third party trackers load correctly Requires: duckduckgo/privacy-test-pages#158 * Bump privacy-test-pages dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for checking convert.ad-company.site our testing domain for ad conversions.
The routing change is to allow the rest of the conversion code to continue to work but make a carve out for /privacy-protections (the plain domain of convert.ad-company.site has to route to /ad)
The rest of the change is just loading the iframes etc to display the cookie properties.