Add detection for WebMidi and Window Placement APIs #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
muodov
commented
Jul 3, 2023
•
muodov
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1204955178666602
kdzwinel
reviewed
Jul 4, 2023
| { | ||
| id: 'window-placement-api', | ||
| run: () => { | ||
| return ('screen' in window && 'isExtended' in window.screen); |
There was a problem hiding this comment.
is this the multi-screen windows API? Google folks are using a different detection technique:
"'Multi-Screen Window Placement': {regEx: /getScreenDetails\\s*\\(\\)/g, where: 'JavaScript', supported: (async () =\u003e 'getScreenDetails' in self)(), featureDetection: `(async () =\u003e 'getScreenDetails' in self)()`, documentation: 'https://developer.chrome.com/articles/multi-screen-window-placement/', blinkFeatureID: 3388},"
Not sure if that's better?
There was a problem hiding this comment.
Both getScreenDetails and isExtended are introduced in the spec, so I guess it doesn't really matter?
There was a problem hiding this comment.
Yeah, I guess their goal is to check if feature is available FULLY. We may not care about that, for us if feature is available even partially it's alrady bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.