Add storage test for setting a cookie via the cookieStore API in a serviceworker #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/cookiestore-sw-test
branch
from
27d92cf to
b7802ed
Compare
sammacbeth
force-pushed
the
sam/cookiestore-sw-test
branch
from
b7802ed to
e6ce242
Compare
kdzwinel
reviewed
Sep 29, 2023
| @@ -158,7 +158,7 @@ const commonTests = [ | |||
| }, | |||
| extra: () => { | |||
| if (window.cookieStore) { | |||
| return cookieStore.get('cookiestoredata').then(cookie => { | |||
| return cookieStore.get('swcookiestoredata').then(cookie => { | |||
There was a problem hiding this comment.
I'm confused why we have swcookiestoredata here and cookiestoredata in the file below? Shouldn't that be the other way around? They don't match up with their store/retrive functions now.
There was a problem hiding this comment.
Sorry, I got the cookie names mixed up. Now I've swapped them around.
|
@KeaganJarvis are we OK making new changes to this project? Or should we wait with merging as you are still setting things up? |
|
I'm assuming we are good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookieStoreAPI is available in serviceworkers, this can circumvent protections that rely on content-scripts.