Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of the surrogate script test page #178

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Dec 1, 2023

The surrogate script test page was a little hard to use. Some expected
results being shown as red, some unexpected results being shown
green. Let's improve that a bit, making it clear to folks what a
success/failure looks like.

@kzar kzar requested a review from kdzwinel December 1, 2023 11:23
The surrogate script test page was a little hard to use. Some expected
results being shown as red, some unexpected results being shown
green. Let's improve that a bit, making it clear to folks what a
success/failure looks like.
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave, this LGTM! Just a note that I think this might be a first time that we are indicating "pass" and "fail" directly, but I think it's warranted - this page was causing a lot of confusion.

@kdzwinel kdzwinel merged commit 7f1dcae into duckduckgo:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants