Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy test pages - small fixes #19

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Privacy test pages - small fixes #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e12ef
Retrieve data from all storage mechanisms (8 -> 14).
kdzwinel Jan 26, 2021
eb1a1a5
https test page - Instead of reporting the url that server sees retur…
kdzwinel Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions privacy-protections/https-upgrades/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ const tests = [
id: 'upgrade-subrequest',
run: () => {
return fetch(`http://${TEST_DOMAIN}/reflect-headers`)
.then(r => r.json())
.then(data => data.url);
.then(r => r.url);
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion privacy-protections/storage-blocking/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ function retrieveData() {
testsSummaryDiv.innerText = `Retrieved data from ${all} storage mechanisms${failed > 0 ? ` (${failed} failed)` : ''}. Click for details.`;
}

tests.forEach(test => {
tests.concat(commonTests).forEach(test => {
all++;

const resultObj = {
Expand Down
1 change: 1 addition & 0 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const fs = require('fs');

function fullUrl(req) {
return url.format({
// note: if server is behind a proxy, and it probably is, you may see 'http' here even if request was 'https'
protocol: req.protocol,
host: req.get('host'),
pathname: req.originalUrl
Expand Down