Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages to simulate HTTP and WebView errors #209

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

nshuba
Copy link
Collaborator

@nshuba nshuba commented May 27, 2024

@nshuba nshuba requested a review from kdzwinel May 27, 2024 19:08
@kdzwinel
Copy link
Member

kdzwinel commented May 27, 2024

Nicely done 👏

The code itself looks great, but I think we can improve the structure so that the name is more specific, it's more transparent what the page does, and we can add more network issues in the future. Let's aim for something similar to https://github.com/duckduckgo/privacy-test-pages/tree/main/viewport , specifically:

  • please create a new /network-error/ folder (more specific name ✅ )
  • in that folder please create an index page that links to couple of error codes (e.g. 401, 403, 500) + connection lost and explains how to use those pages (more explanation what the page does ✅ )
  • in that folder let's have /server/ subfolder with relevant backend routes (just modularization and avoiding one big server.js file ✅ )
  • from the main index.html page let's create one link "Network errors" in the "Browser features" category (hopefully slightly easier to find ✅ )

LMK if you'd like to discuss anything above!

@nshuba
Copy link
Collaborator Author

nshuba commented May 28, 2024

Thanks @kdzwinel! Addressed ✅

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and the code LGTM - approved! Thank you :)

@kdzwinel kdzwinel merged commit 82d8af7 into main May 28, 2024
1 check passed
@kdzwinel kdzwinel deleted the nastia/http_errors branch May 28, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants