Add ESLint standard config #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Feb 15, 2021
| @@ -1,3 +1,3 @@ | |||
| // https://github.com/flitbit/diff | |||
There was a problem hiding this comment.
I'd avoid making changes to this file since it's external and minified. In fact, you added it to the ignore list - is .eslintingore working correctly?
There was a problem hiding this comment.
Yeah I added that after, fixed :) thanks for noticing
jonathanKingston
force-pushed
the
eslint
branch
from
a02b0fe to
93b6112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added eslint 'standard' to match the extension.
For the record I haven't tested it thoroughly.