Add audio playback demo to verify audio fingerprint code works as exp… #33
Conversation
features/audio-playback/index.html
Outdated
| this.outputElement.addEventListener('click', this); | ||
| this.sampleElement.addEventListener('ended', this, false); | ||
|
|
||
| this.offlineAudioContext = new OfflineAudioContext(1, 44100 * 40, 44100); |
There was a problem hiding this comment.
Webkit is still prefixing both OfflineAudioContext and AudioContext, but IMO we should support it :(
There was a problem hiding this comment.
I think... this should work in Safari but I don't have a copy to check. As mentioned this won't be an issue soon given they've added a commit to webkit to add support for some of these things.
There was a problem hiding this comment.
Sorry, it still doesn't work on Safari (14.0.3) :( renderedBuffer is undefined (see screenshot). If this can work (Safari supports all relevant APIs) you can use jsbin+browserstack to debug.
jonathanKingston
force-pushed
the
audio-playback-check
branch
2 times, most recently
from
fbbb5d6 to
decf8f2
Compare
| @@ -0,0 +1,2 @@ | |||
| Audio sample: THROW THE SWITCH by Robert Meyers | |||
There was a problem hiding this comment.
Sorry for nitpicking but it takes a lot of time for the modified sample to start playing. I'm guessing that it'd be faster if we used a shorter input sample (current one is 6min)?
|
nudge nudge - you now have access to Safari I hear :) |
jonathanKingston
force-pushed
the
audio-playback-check
branch
from
decf8f2 to
d77dbf5
Compare
|
OK, to merge this:
|
…ected