CSP Extension ID leak PoC #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
10 tasks
kdzwinel
reviewed
Apr 14, 2021
There was a problem hiding this comment.
Nice work @sammacbeth 🙌 I left couple of comments that should be addressed before merging.
|
Thanks for the comments @kdzwinel - I've updated the PR addressing all of them. |
kdzwinel
approved these changes
Apr 14, 2021
| @@ -3,6 +3,9 @@ | |||
| "version": "1.0.0", | |||
| "description": "This project contains a collection of pages that are meant to be used for testing various privacy and security features of browsers and browser extensions.", | |||
| "main": "server.js", | |||
| "engines": { | |||
| "node": ">=12.19" | |||
There was a problem hiding this comment.
it's either 12.19+ or 14.10+ (I know because I had to update node for this to work :) ). I hope that glitch will work with this.
There was a problem hiding this comment.
Yeah this was the minimum for crypto.randomInt - looks like it worked on glitch though :)
| res.end(contents.replace('%%UID%%', id)); | ||
| }); | ||
| // ensure IDs get deleted after 60s | ||
| setTimeout(() => cspIds.delete(id), 60000); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test page which reports extension scripts which can be leaked (and blocked) via a CSP report.