tidy up, surrogate and links pages #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… couple of pages that demonstrate links
# Conflicts: # index.html
kdzwinel
reviewed
Aug 10, 2020
index.html
Outdated
| <li><a href="./features/geolocation.html">Geolocation</a> | ||
| <li><a href="./features/geolocation.html">Geolocation</a></li> | ||
| <li><a href="./features/target-blank.html">Links Open in New Window</a> | ||
| <li><a href="./features/closeable.html">window.close() Link</a> |
There was a problem hiding this comment.
👀 I wish there was one more space there…
There was a problem hiding this comment.
this is why the internet is running out of space!
trackers/1major-with-surrrogate.html
Outdated
| <meta name="viewport" content="width=device-width"> | ||
| <title>1 major tracker loaded via script</title> | ||
|
|
||
| <script src="//static.doubleclick.net/tracker.js"></script> |
There was a problem hiding this comment.
I don't think we surrogate this url? You should do doubleclick.net/tag/js/gpt.js or doubleclick.net/instream/ad_status.js IMO.
Also, <title> needs an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds