Check if we can load a surrogate even if the integrity mismatches. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
integrity-surrogate
branch
from
b267dc5 to
3566677
Compare
kdzwinel
reviewed
Jul 16, 2021
kdzwinel
reviewed
Jul 16, 2021
| integrity: 'sha512-1xNTXD/ZeaKg/Xjb6De9la7CXo5gC1lMk+beyKo691KJrjlj0HbZG6frzK0Wo6bm96i9Cp6w/WB4vSN/8zDBLQ==', | ||
| notes: 'Fails loading in all browsers despite we think it should be possible for the extension to load this.', | ||
| shouldFail: false, | ||
| test: () => { return !!(window.ga && Object.keys(window.ga.create()).length === 0); }, |
There was a problem hiding this comment.
This will be green if surrogate successfully loads, right? It will still be red if extension is disabled and original loads?
There was a problem hiding this comment.
Yes, although the integrity isn't valid also so shouldn't pass either.
There was a problem hiding this comment.
AKA this should only pass if the extension redirecting to a local extension resource is carved out within the browser code
Co-authored-by: Konrad Dzwinel <konrad@duckduckgo.com>
|
LGTM! Thanks 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kdzwinel / @jdorweiler this currently fails should I set
shouldFailto true?The idea here is we would like the browser to permit us loading a surrogate when the SRI check doesn't match. This would allow us to have surrogates for the likes of fingerprint.js and f***Adblock etc.
My hope is we can direct Chrome/Firefox etc at this page when we raise issues.