Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test page for global JS leaks #52

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Add test page for global JS leaks #52

merged 7 commits into from
Aug 17, 2021

Conversation

sammacbeth
Copy link
Collaborator

https://app.asana.com/0/1186013049913869/1200703914275433/f

Adds a new test page that compares window to vanilla browsers to see if changes to JS globals are detectable.

@sammacbeth sammacbeth requested a review from kdzwinel August 12, 2021 10:01
kdzwinel
kdzwinel reviewed Aug 12, 2021
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, great job. I left couple of notes.

security/js-leaks.html Outdated Show resolved Hide resolved
security/js-leaks.html Show resolved Hide resolved
security/leaks.js Show resolved Hide resolved
security/leaks.js Outdated Show resolved Hide resolved
security/leaks.js Outdated Show resolved Hide resolved
security/leaks.js Outdated Show resolved Hide resolved
security/leaks.js Show resolved Hide resolved
@sammacbeth
Copy link
Collaborator Author

Thanks @kdzwinel - I've updated with the changes you asked for!

kdzwinel
kdzwinel approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three more nits to keep same format for all the pages. Feel free to merge after this.

Great work 🙌

security/leaks.js Show resolved Hide resolved
security/leaks.js Show resolved Hide resolved
security/js-leaks.html Outdated Show resolved Hide resolved
sammacbeth and others added 3 commits August 12, 2021 16:16
@sammacbeth @kdzwinel
Update security/leaks.js
43d4f4c 
Co-authored-by: Konrad Dzwinel <kdzwinel@gmail.com>
@sammacbeth
Add download buttons
2662617
@sammacbeth
Fix linting
b2b73db
@sammacbeth sammacbeth merged commit 7dad218 into duckduckgo:gh-pages Aug 17, 2021
@sammacbeth sammacbeth deleted the sam/js-leaks branch August 17, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdzwinel kdzwinel kdzwinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @kdzwinel