Loop protection in HTTPS upgrades #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
force-pushed
the
konrad/https-loop
branch
from
8391f8a to
bfaf018
Compare
kdzwinel
commented
Sep 29, 2021
| @@ -174,7 +174,7 @@ function downloadTheResults () { | |||
| const a = document.createElement('a'); | |||
| const url = window.URL.createObjectURL(new Blob([data], { type: 'application/json' })); | |||
| a.href = url; | |||
| a.download = 'fingerprinting-results.json'; | |||
| a.download = 'https-upgrades-results.json'; | |||
There was a problem hiding this comment.
unrelated change - renaming downloaded file to match test name
kdzwinel
commented
Sep 29, 2021
| </head> | ||
| <body> | ||
| <script> | ||
| const MAX = 15; |
There was a problem hiding this comment.
if loop protection doesn't kick in after 15 attempts - give up
kdzwinel
commented
Sep 29, 2021
| const tests = [ | ||
| { | ||
| id: 'upgrade-navigation', | ||
| run: () => { |
There was a problem hiding this comment.
most of this file, besides the contents of this test, is just a template. We should probably extract it to some reusable helpers instead of copying it over and over
kdzwinel
force-pushed
the
konrad/https-loop
branch
from
290fd10 to
d6f6aab
Compare
jonathanKingston
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain is HTTPS upgradable but page will constantly try to downgrade to HTTP. Client should detect that and allow page to load. Unfortunately our extension seems to have a bug and doesn't do it.
https://app.asana.com/0/1186013049913869/1201057222436407/f