AMP link protection page #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Nov 8, 2021
kdzwinel
approved these changes
Nov 8, 2021
privacy-protections/amp/index.html
Outdated
| </li> | ||
| <li> | ||
| <p><a href="https://www.independent.co.uk/news/world/americas/us-politics/covid-vaccine-mandate-kids-san-francisco-b1951340.html?amp">?amp link</a></p> | ||
| <p class="expected">Expected: https://www.independent.co.uk/news/world/americas/us-politics/covid-vaccine-mandate-kids-san-francisco</p> |
There was a problem hiding this comment.
This was a good catch actually. I think independent in this case doesn't have the canonical element loaded when DOMContentLoaded fires. I have an idea to fix this.
| </li> | ||
| <li> | ||
| <p><a href="https://www-wpxi-com.cdn.ampproject.org/v/s/www.wpxi.com/news/top-stories/pihl-bans-armstrong-student-section-hockey-games-after-vulgar-chants-directed-female-goalie/G2RP5FZA3ZDYRLFSWGDGQH2MY4/?amp_js_v=a6&_gsa=1&outputType=amp&usqp=mq331AQKKAFQArABIIACAw%3D%3D&fbclid=IwAR1TYTsjFEPy42VACpBR0n2jP-6whynOxwVqxpDMTWIRgW2vFlj573xVkEI#aoh=16358554203777&referrer=https%3A%2F%2Fwww.google.com&_tf=From%20%251%24s&share=https%3A%2F%2Fwww.wpxi.com%2Fnews%2Ftop-stories%2Fpihl-bans-armstrong-student-section-hockey-games-after-vulgar-chants-directed-female-goalie%2FG2RP5FZA3ZDYRLFSWGDGQH2MY4%2F">ampproject.org with parameters</a></p> | ||
| <p class="expected">Expected: https://www.wpxi.com/news/top-stories/pihl-bans-armstrong-student-section-hockey-games-after-vulgar-chants-directed-female-goalie/G2RP5FZA3ZDYRLFSWGDGQH2MY4/?amp_js_v=a6&_gsa=1&outputType=amp&usqp=mq331AQKKAFQArABIIACAw%3D%3D&fbclid=IwAR1TYTsjFEPy42VACpBR0n2jP-6whynOxwVqxpDMTWIRgW2vFlj573xVkEI#aoh=16358554203777&referrer=https%3A%2F%2Fwww.google.com&_tf=From%20%251%24s&share=https%3A%2F%2Fwww.wpxi.com%2Fnews%2Ftop-stories%2Fpihl-bans-armstrong-student-section-hockey-games-after-vulgar-chants-directed-female-goalie%2FG2RP5FZA3ZDYRLFSWGDGQH2MY4%2F</p> |
There was a problem hiding this comment.
this is still an amp page (<html amp=true), although not served by google, is that expected?
There was a problem hiding this comment.
Kind of yes? This triggers the simple extraction. We're not recursively checking the links in case we get a double AMP link. I'll look in to the feasibility of this and update the page if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page will have sample links for AMP protection.