Add autoconsent test page #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kdzwinel
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Thanks @sammacbeth ! Looks great, but please link this test page from index.html + I left one more comment. Feel free to merge after that.
| @@ -0,0 +1,82 @@ | |||
| // populate test sites | |||
| const testSites = { | |||
There was a problem hiding this comment.
why this format is easier than keeping it in HTML? We use this format elsewhere and it's easier to update in the future?
There was a problem hiding this comment.
This way is less verbose, and allows test-cases to be easily copied over to/from the tests in the autoconsent project: https://github.com/cliqz-oss/autoconsent/blob/master/addon/test.ts#L82-L91
sammacbeth
force-pushed
the
sam/autoconsent
branch
from
80189a6 to
a06ebfb
Compare
Co-authored-by: Konrad Dzwinel <kdzwinel@gmail.com>
sammacbeth
force-pushed
the
sam/autoconsent
branch
from
a06ebfb to
274fae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic test page for consent popup management.