Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement test pages for platform-level privacy impacting APIs #74

Merged
merged 35 commits into from
May 4, 2022
Merged

Implement test pages for platform-level privacy impacting APIs #74

merged 35 commits into from
May 4, 2022

Conversation

englehardt
Copy link
Collaborator

@englehardt
Initial commit of storage partitioning tests
3097a2e 
This is a very WIP commit. Needs a ton of refactoring, cleanup, and
expansion.
@englehardt
Fix eslint issues
d4c6f13
@englehardt
Update test page to use redirections within the same tab.
063a624 
This also stops sending back results via window.opener and instead sends
them via localStorage. To achieve this, I propagate the results through all
of the test pages via a query parameter. We will want to move this to
server-side storage since the number of test results will grow quite
long and lead to URLs in the 10s of thousands of characters.
@englehardt
Adding license
a219d05
@englehardt
Update test pages to work on Webkit and add new APIs
78dee89
@englehardt
Fix flakey serviceWorker test
4a54b1e
@englehardt
Small cleanup
79763b6
@englehardt
More service worker cleanup
23ada5e
@englehardt
Initial commit of cache partitioning tests
bf7cdf1 
There are still a few bugs to fix and some refactoring necessary.
@englehardt
Fixing favicon test and adding a WIP HSTS test.
329cf80 
HSTS requires HTTPS, so I've added support for that (including setup
documentation).
@englehardt
Fix HSTS test setup
3a14991
@englehardt
Update test verification, accounting for unsupported APIs.
090cb5e 
sessionStorage still needs special handling...
@englehardt
Close test window when finished
6eaaf5a
@englehardt
Fix cache test output when unsupported
bea20b4
@englehardt
Migrate from query string to server-side storage of intermediate results
861e59d
@englehardt
Starting some cleanup
d5b1fa3
kdzwinel
kdzwinel reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!I did a first quick read-through. I'll post more comments later today.

@englehardt englehardt requested a review from kdzwinel April 7, 2022 22:35
@englehardt englehardt marked this pull request as ready for review April 7, 2022 22:36
@englehardt englehardt changed the title [WIP] Implement test pages for platform-level privacy impacting APIs Implement test pages for platform-level privacy impacting APIs Apr 7, 2022
kdzwinel
kdzwinel reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this grew BIG!

I tested locally - no issues found, reviewed the code - found some nits and left couple questions. Other than that it looks good to go 🚀

@englehardt englehardt merged commit 5c0dee5 into main May 4, 2022
@englehardt englehardt deleted the senglehardt/platform-tests branch May 4, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdzwinel kdzwinel kdzwinel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@englehardt @kdzwinel