Framed autofill #79
Framed autofill #79
Conversation
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
| <h2>Cross origin iframe</h2> | ||
| <iframe src="https://good.third-party.site/autofill/frame-child.html" id="frame-form-cross-origin"></iframe> |
There was a problem hiding this comment.
I've added a cross-origin iframe for completeness as this was discussed extensively during the Android investigation, though it doesn't really make much difference for our purposes. I'm not entirely sure if using https://good.third-party.site is the correct way to do this, nor if it will actually work. AFAIK, we're not adding cross-origin iframes restrictions in CSPs so they should work by default. Please let me know if I should add anything else to make this work.
There was a problem hiding this comment.
without knowing whole context this LGTM. good.third-party.site will work, path checks out. If you used other option (bad. , broken.) frame would be blocked/restricted.
|
@jonathanKingston I piggybacked your branch for https://app.asana.com/0/0/1201935429432145/f. Let me know what you think. |
There was a problem hiding this comment.
@GioSensation please update the title and drop that htmk file and feel free to merge 👍
| <h2>Cross origin iframe</h2> | ||
| <iframe src="https://good.third-party.site/autofill/frame-child.html" id="frame-form-cross-origin"></iframe> |
There was a problem hiding this comment.
without knowing whole context this LGTM. good.third-party.site will work, path checks out. If you used other option (bad. , broken.) frame would be blocked/restricted.
|
Yeah agree with Konrad's comments here, drop the htmk file :). Happy to make the changes if you're busy also. Thanks for making the changes :) |
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Adds forms within iframes to test autofill.