Add a bunch of test cases for autofill autoprompt #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
kdzwinel
reviewed
Jul 29, 2022
| </head> | ||
|
|
||
| <body> | ||
| <p><a href="../index.html">[Home]</a></p> |
There was a problem hiding this comment.
this doesn't work because we are two levels deep (autofill/autoprompt/). Same for all test case pages.
| @@ -75,6 +75,16 @@ <h2>Autofill</h2> | |||
| <li><a href="./autofill/modal.html">Email autofill form within self-closing modal</a></li> | |||
| <li><a href="./autofill/form-submission.html">Form submission detection and autofill</a></li> | |||
| <li><a href="./autofill/frame-form-submission-parent.html">Form submission detection and autofill within an iframe</a></li> | |||
| <li> | |||
| Autoprompt | |||
There was a problem hiding this comment.
Can we expand a bit more what autoprompt is? I'm guessing something like "automatically prompt to store credentials after login form is detected"?
| <li> | ||
| Autoprompt | ||
| <ul> | ||
| <li><a href="./autofill/autoprompt/case-1.html">Case 1</a></li> |
There was a problem hiding this comment.
It'd be good for those cases to explain them a bit, so that we don't have to rely on remembering the numbers e.g. "Form below the fold" instead of "Case 3".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: https://app.asana.com/0/0/1202658859281356/f
Reviewer: @shakyShane
Description
Adds a bunch of test cases for autofill autoprompt. The expected behaviour is added to the pages themselves.