add a page for testing autofill for login forms embedded in an iframe #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GioSensation
approved these changes
Jul 29, 2022
| e.preventDefault(); | ||
| e.stopImmediatePropagation(); | ||
| // Note that form.submit() does not fire a submit event | ||
| clickForm.submit(); |
There was a problem hiding this comment.
I suggest also adding a visual indication that the form was indeed submitted. See this as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: https://app.asana.com/0/72649045549333/1201816478631739/f
Add a new page for testing autofill for logins within an iframe. There are related pages (parent, child) to test autofill with iframes, but they target the autofill email integration and not logins. Felt like adding a new page makes more sense instead of extending the already existing one to avoid breaking tests or whatnot.