-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable single test runs on referrer trimming #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why we want to have those shortcuts in the HTML, but why do we need to pass this ID around is unclear to me? We get testid from the url param, we pass it to the test, it ends up in the url to the come-back page, gets passed back by the come-back page in the url - and then I'm not sure what happens?
When the test page runs the test it:
It does this for each test in the array. Currently if we pass a testid when we run the test we get the filtered array which calls the specified test. When the page comes back with the results we've lost the id so it operates on the full array of tests which puts the last run in the wrong spot and continues with the others. With this change passing along the testid, when we come back to the results page the testid will ensure the array of tests is filtered again and will stop with just that one test instead of continuing with the others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, that makes sense, thanks for explanation!
Sorry, I had to revert it because it was breaking the main functionality of "start test". The way I tested (Safari):
Expected: full test runs normally |
This PR passes around the testid as well as adds manual test links to run single tests on this page.