MLB Boxscore - Whitespace Fix

[sdougbrown]

Some whitespace crept into the compiled template, which makes the end result look a little skewed. 😄

to @bsstoner
cc @thm

[bsstoner]

Do you think we can we solve this at the compile level instead of needing to add all the extra syntax to the templates? /cc @zachthompson @russellholt

[russellholt]

I explored removing all leading white space from precompiled templates once - it worked (seemed to) and saved otherwise unminifiable space but it needs this large scale regression testing before I'd trust it. Is this what you mean?

[zachthompson]

Are you referring to the indentation in the rendering?

I think this is fixed in handlebars 3.x:

We could, as Russell suggests, remove leading white space pretty easily.

[bsstoner]

We're doing it with the internal templates. Seems like maybe we could compile the same way in open source to avoid confusion? Where is the code that compiles the templates for open source?

Internally we're using a grunt task in core with a step that removes new lines and spaces. /www-release/frontend/Gruntfile.jsL54

[zachthompson]

Handlebars templates are compiled here - https://github.com/duckduckgo/p5-dist-zilla-plugin-buildshareassets/blob/master/lib/Dist/Zilla/Plugin/BuildShareAssets.pm#L281

[sdougbrown]

Merging now to fix the immediate issue with MLB scores - I agree that we should address the issue globally, though.