Skip to content

Commit

Permalink
Merge #180
Browse files Browse the repository at this point in the history
180: Replace usage of distutils.version with packaging.version. r=duckinator a=duckinator



Co-authored-by: Ellen Marie Dash <me@duckie.co>
  • Loading branch information
bors[bot] and duckinator authored Aug 1, 2020
2 parents b42d77c + 549ba95 commit d34db75
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions bork/github.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
from distutils.version import LooseVersion
import fnmatch
import json
from pathlib import Path
from urllib.request import urlopen

import packaging.version

from .asset_manager import download_assets
from .filesystem import find_files
from .github_api import GithubApi
Expand Down Expand Up @@ -132,7 +133,7 @@ def _get_release_info(repo, name, draft=False, prerelease=False):
# Find the latest
release = max(
releases,
key=lambda x: LooseVersion(x['tag_name'].lstrip('v')),
key=lambda x: packaging.version.parse(x['tag_name']).public,
)
log.info("Selected release '%s' as latest", release['name'])
else:
Expand Down

0 comments on commit d34db75

Please sign in to comment.