Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define “success” as a single CI task, refactor Bors & release config #237

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Define “success” as a single CI task, refactor Bors & release config #237

merged 2 commits into from
Jan 4, 2021

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Jan 2, 2021

  • Introduced aliases for each task group
  • Introduced a “CI success” task that depends on all relevant tasks
  • Refactored the Bors config and release task to depend on that task

Closes #236

@nbraud
Copy link
Collaborator Author

nbraud commented Jan 2, 2021

OK, I think Cirrus does not like me telling it to run an empty image 😹
I'm giving it a busybox image instead, hopefully that's enough (and if it wants a script, I can say /bin/true :3)

@nbraud
Copy link
Collaborator Author

nbraud commented Jan 3, 2021

rebased to fix merge conflict, boops @duckinator.

@duckinator
Copy link
Owner

bors r+

bors bot added a commit that referenced this pull request Jan 3, 2021
237: Define “success” as a single CI task, refactor Bors & release config r=duckinator a=nbraud

- [x] Introduced aliases for each task group
- [x] Introduced a “CI success” task that depends on all relevant tasks
- [x] Refactored the Bors config and release task to depend on that task

Closes #236

Co-authored-by: nicoo <nicoo@mur.at>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2021

Build failed:

  • CI success

@nbraud
Copy link
Collaborator Author

nbraud commented Jan 4, 2021

WTF?
bors retry

@bors
Copy link
Contributor

bors bot commented Jan 4, 2021

Build succeeded:

  • CI success

@bors bors bot merged commit 8f0f399 into duckinator:master Jan 4, 2021
@nbraud nbraud deleted the refactor-bors branch January 4, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate better bors/GitHub integration?
2 participants