only signal done when close is actually finished #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Make the plugin only signal done when socket.io is actually closed. Otherwise one might end up closing e.g. the Mongo connection the adapters are depending on. Will be even more relevant after socketio/socket.io#4971 has been merged.
Issues reference:
Checklist:
pnpm lint
locally prior to submission?pnpm build
of your changes locally?pnpm test
of your changes locally?