Clean up receive_buffer. Fixes memory leak. (#141)

Refs django/channels#1181
dudleyhunt86 · Nov 27, 2018 · 9fb41e0 · 9fb41e0
1 parent b2db224
commit 9fb41e0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/channels_redis/core.py b/channels_redis/core.py
@@ -383,6 +383,7 @@ async def receive(self, channel):
                     except asyncio.CancelledError:
                         # Ensure all tasks are cancelled if we are cancelled.
                         # Also see: https://bugs.python.org/issue23859
+                        del self.receive_buffer[channel]
                         for task in tasks:
                             if not task.cancel():
                                 assert task.done()
@@ -433,6 +434,9 @@ async def receive(self, channel):
                             else:
                                 self.receive_buffer[message_channel].put_nowait(message)
                             message = None
+                        except:
+                            del self.receive_buffer[channel]
+                            raise
                         finally:
                             self.receive_lock.release()