Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Use PHPStan for static code analysis #20

Merged
merged 37 commits into from
May 3, 2022
Merged

Use PHPStan for static code analysis #20

merged 37 commits into from
May 3, 2022

Conversation

sgerrand
Copy link
Contributor

💁 PHPStan is a static code analysis tool which is popular in the PHP community. These changes add it to the development toolchain and run it as part of continuous integration.

@sgerrand sgerrand added this to the v1.0.0 milestone Apr 29, 2022
Sasha Gerrand added 26 commits April 29, 2022 16:50
------ -----------------------------------------------------------------------
  Line   Duffel/Api/AbstractApi.php
 ------ -----------------------------------------------------------------------
  13     Property Duffel\Api\AbstractApi::$client has no type specified.
  23     Method Duffel\Api\AbstractApi::get() has no return type specified.
  29     Method Duffel\Api\AbstractApi::post() has no return type specified.
  41     Method Duffel\Api\AbstractApi::put() has no return type specified.
  53     Method Duffel\Api\AbstractApi::delete() has no return type specified.
  67     Casting to string something that's already string.
 ------ ------------------------------------------------------------------
  Line   Duffel/Api/Aircraft.php
 ------ ------------------------------------------------------------------
  8      Method Duffel\Api\Aircraft::all() has no return type specified.
  12     Method Duffel\Api\Aircraft::show() has no return type specified.
 ------ ------------------------------------------------------------------
This component will be useful for defining the input requirements for
calling API endpoints.
@sgerrand sgerrand merged commit cd0e651 into main May 3, 2022
@sgerrand sgerrand deleted the phpstan branch May 3, 2022 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant