Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #122

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Misc doc changes #122

merged 2 commits into from
Oct 26, 2021

Conversation

kianmeng
Copy link
Contributor

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the main reference doc for this
Elixir library which leverage on latest features of ExDoc.

@sgerrand sgerrand self-assigned this Jun 9, 2021
@sgerrand
Copy link
Contributor

👋 @kianmeng: Thanks for your contribution! There's a lot of changes in this single commit. I'll review them for you today. In the meantime, would you please rebase your branch to resolve the conflict in mix.lock.

@kianmeng
Copy link
Contributor Author

@kianmeng: Thanks for your contribution! There's a lot of changes in this single commit. I'll review them for you today. In the meantime, would you please rebase your branch to resolve the conflict in mix.lock.

@sgerrand Sorry, just noticed your message. I've fixed the conflict. Thanks.

@sgerrand
Copy link
Contributor

Thank you! ♥️

Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

kianmeng and others added 2 commits October 26, 2021 12:00
Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the main reference doc for this
Elixir library which leverage on latest features of ExDoc.
The previous change had forced a downgrade of `ex_doc`, from 0.25.5 -> 0.24.2.
@sgerrand sgerrand merged commit 1196753 into duffelhq:main Oct 26, 2021
@sgerrand
Copy link
Contributor

Thank you again @kianmeng for your contribution!

@sgerrand sgerrand removed their assignment Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants