Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix for a dialyzer issue #96

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Small fix for a dialyzer issue #96

merged 1 commit into from
Jan 26, 2021

Conversation

djthread
Copy link
Contributor

I think we want to allow nil in the metadata struct here, yes? This seemed to fix a dialyzer error I encountered.

Thanks for sharing the nice library!

Base automatically changed from master to main January 26, 2021 17:52
sgerrand
sgerrand approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sgerrand
Copy link
Contributor

Thank you for your contribution!

@sgerrand sgerrand merged commit 85e5751 into duffelhq:main Jan 26, 2021
@sgerrand sgerrand added the bug label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgerrand sgerrand sgerrand approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djthread @sgerrand