Skip to content

Commit

Permalink
Merge pull request Expensify#20560 from tienifr/fix/20200-no-error-me…
Browse files Browse the repository at this point in the history
…ssage-with-similar-routing-and-account-number

Fix 20200: Fails to Proceed with Similar Routing and Account Numbers Without Error Message
  • Loading branch information
aldo-expensify committed Jun 20, 2023
2 parents 6d92bc3 + 865dd65 commit f0c6631
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,7 @@ export default {
restrictedBusiness: 'Please confirm company is not on the list of restricted businesses',
routingNumber: 'Please enter a valid routing number',
accountNumber: 'Please enter a valid account number',
routingAndAccountNumberCannotBeSame: 'The routing number and account number cannot be the same',
companyType: 'Please select a valid company type',
tooManyAttempts: 'Due to a high number of login attempts, this option has been temporarily disabled for 24 hours. Please try again later or manually enter details instead.',
address: 'Please enter a valid address',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ export default {
restrictedBusiness: 'Por favor, confirma que la empresa no está en la lista de negocios restringidos',
routingNumber: 'Por favor, introduce un número de ruta válido',
accountNumber: 'Por favor, introduce un número de cuenta válido',
routingAndAccountNumberCannotBeSame: 'El número de ruta y el número de cuenta no pueden ser iguales',
companyType: 'Por favor, selecciona un tipo de compañía válido',
tooManyAttempts:
'Debido a la gran cantidad de intentos de inicio de sesión, esta opción se ha desactivado temporalmente durante 24 horas. Vuelve a intentarlo más tarde o introduce los detalles manualmente.',
Expand Down
3 changes: 3 additions & 0 deletions src/pages/ReimbursementAccount/BankAccountManualStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ class BankAccountManualStep extends React.Component {
if (!routingNumber || !CONST.BANK_ACCOUNT.REGEX.SWIFT_BIC.test(routingNumber) || !ValidationUtils.isValidRoutingNumber(routingNumber)) {
errorFields.routingNumber = 'bankAccount.error.routingNumber';
}
if (values.accountNumber === routingNumber) {
errorFields.accountNumber = this.props.translate('bankAccount.error.routingAndAccountNumberCannotBeSame');
}
if (!values.acceptTerms) {
errorFields.acceptTerms = 'common.error.acceptTerms';
}
Expand Down

0 comments on commit f0c6631

Please sign in to comment.