Use error details in messages #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendoncaulkins
commented
Apr 17, 2020
| @@ -200,7 +200,7 @@ export class ProfileComponent extends BaseFormComponent<IUser> | |||
| } | |||
|
|
|||
| convertTypeToPhoneType(type: string): PhoneType { | |||
| return $enum(PhoneType).asValueOrThrow(type) | |||
| return PhoneType[$enum(PhoneType).asKeyOrThrow(type)] | |||
There was a problem hiding this comment.
The list of types passed into the drop-down are from $enum(PhoneTypes).getKeys(), so we want to verify the value we get back is a key (asKeyOrThrow) and then look that up in the enum.
brendoncaulkins
commented
Apr 17, 2020
Comment on lines
+78
to
+80
| return `${label} must be at least ${errorDetails?.requiredLength ?? 2} characters` | ||
| case 'maxlength': | ||
| return `${label} can\'t exceed 50 characters` | ||
| return `${label} can\'t exceed ${errorDetails?.requiredLength ?? 50} characters` |
There was a problem hiding this comment.
?? is the cool new TypeScript nullish operator.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#nullish-coalescing
There was a problem hiding this comment.
@brendoncaulkins yup, updated Ch7 with that info
duluca
approved these changes
Apr 19, 2020
Comment on lines
+78
to
+80
| return `${label} must be at least ${errorDetails?.requiredLength ?? 2} characters` | ||
| case 'maxlength': | ||
| return `${label} can\'t exceed 50 characters` | ||
| return `${label} can\'t exceed ${errorDetails?.requiredLength ?? 50} characters` |
There was a problem hiding this comment.
@brendoncaulkins yup, updated Ch7 with that info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Change Description
This adds an enhancement to the FormError directive, that utilizes the error Object passed back from the Reactive Forms validators to help construct the Min/Max length error messages.
Developer Checklist
npm run style:fixfor code style enforcementnpm run lint:fixfor lintingnpm auditto discover vulnerabilities