ngrx#955 test fix

dummdidumm · Jul 30, 2018 · c2b1ed6 · c2b1ed6
1 parent 9e9c4f5
commit c2b1ed6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 15 deletions.
diff --git a/modules/store-devtools/spec/extension.spec.ts b/modules/store-devtools/spec/extension.spec.ts
@@ -1,15 +1,13 @@
 import { LiftedActions, ComputedState, LiftedAction } from './../src/reducer';
 import { PerformAction, PERFORM_ACTION } from './../src/actions';
-import { ActionSanitizer, StateSanitizer } from './../src/config';
 import {
   ReduxDevtoolsExtensionConnection,
   ReduxDevtoolsExtensionConfig,
 } from './../src/extension';
 import { Action } from '@ngrx/store';
 
-import { LiftedState } from '../';
 import { DevtoolsExtension, ReduxDevtoolsExtension } from '../src/extension';
-import { createConfig, noMonitor } from '../src/config';
+import { createConfig } from '../src/config';
 import { unliftState } from '../src/utils';
 
 function createOptions(
@@ -97,7 +95,8 @@ describe('DevtoolsExtension', () => {
   it('should connect with default options', () => {
     devtoolsExtension = new DevtoolsExtension(
       reduxDevtoolsExtension,
-      createConfig({})
+      createConfig({}),
+      null
     );
     // Subscription needed or else extension connection will not be established.
     devtoolsExtension.actions$.subscribe(() => null);
@@ -116,7 +115,8 @@ describe('DevtoolsExtension', () => {
         // these two should not be added
         actionSanitizer: myActionSanitizer,
         stateSanitizer: myStateSanitizer,
-      })
+      }),
+      null
     );
     // Subscription needed or else extension connection will not be established.
     devtoolsExtension.actions$.subscribe(() => null);
@@ -139,7 +139,8 @@ describe('DevtoolsExtension', () => {
       createConfig({
         name: 'ngrx-store-devtool-todolist',
         serialize: customSerializer,
-      })
+      }),
+      null
     );
     // Subscription needed or else extension connection will not be established.
     devtoolsExtension.actions$.subscribe(() => null);
@@ -152,7 +153,8 @@ describe('DevtoolsExtension', () => {
     it('should send notification with default options', () => {
       devtoolsExtension = new DevtoolsExtension(
         reduxDevtoolsExtension,
-        createConfig({})
+        createConfig({}),
+        null
       );
       const defaultOptions = createOptions();
       const action = {} as LiftedAction;
@@ -176,7 +178,8 @@ describe('DevtoolsExtension', () => {
           // these two should not be added
           actionSanitizer: myActionSanitizer,
           stateSanitizer: myStateSanitizer,
-        })
+        }),
+        null
       );
       const options = createOptions(
         'ngrx-store-devtool-todolist',
@@ -215,7 +218,8 @@ describe('DevtoolsExtension', () => {
         beforeEach(() => {
           devtoolsExtension = new DevtoolsExtension(
             reduxDevtoolsExtension,
-            createConfig({})
+            createConfig({}),
+            null
           );
           // Subscription needed or else extension connection will not be established.
           devtoolsExtension.actions$.subscribe(() => null);
@@ -252,7 +256,8 @@ describe('DevtoolsExtension', () => {
             reduxDevtoolsExtension,
             createConfig({
               actionSanitizer: testActionSanitizer,
-            })
+            }),
+            null
           );
           // Subscription needed or else extension connection will not be established.
           devtoolsExtension.actions$.subscribe(() => null);
@@ -297,7 +302,8 @@ describe('DevtoolsExtension', () => {
             reduxDevtoolsExtension,
             createConfig({
               stateSanitizer: testStateSanitizer,
-            })
+            }),
+            null
           );
           // Subscription needed or else extension connection will not be established.
           devtoolsExtension.actions$.subscribe(() => null);
@@ -341,7 +347,8 @@ describe('DevtoolsExtension', () => {
             createConfig({
               actionSanitizer: testActionSanitizer,
               stateSanitizer: testStateSanitizer,
-            })
+            }),
+            null
           );
           // Subscription needed or else extension connection will not be established.
           devtoolsExtension.actions$.subscribe(() => null);
@@ -372,7 +379,8 @@ describe('DevtoolsExtension', () => {
     beforeEach(() => {
       devtoolsExtension = new DevtoolsExtension(
         reduxDevtoolsExtension,
-        createConfig({})
+        createConfig({}),
+        null
       );
       // Subscription needed or else extension connection will not be established.
       devtoolsExtension.actions$.subscribe(() => null);
@@ -406,7 +414,8 @@ describe('DevtoolsExtension', () => {
     beforeEach(() => {
       devtoolsExtension = new DevtoolsExtension(
         reduxDevtoolsExtension,
-        createConfig({})
+        createConfig({}),
+        null
       );
       // Subscription needed or else extension connection will not be established.
       devtoolsExtension.actions$.subscribe(() => null);

diff --git a/modules/store-devtools/src/extension.ts b/modules/store-devtools/src/extension.ts
@@ -71,7 +71,7 @@ export class DevtoolsExtension {
   constructor(
     @Inject(REDUX_DEVTOOLS_EXTENSION) devtoolsExtension: ReduxDevtoolsExtension,
     @Inject(STORE_DEVTOOLS_CONFIG) private config: StoreDevtoolsConfig,
-    @Optional() private router: Router
+    @Optional() private router: Router | null
   ) {
     this.devtoolsExtension = devtoolsExtension;
     this.createActionStreams();