GTM submission tracking #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniGrbic
requested changes
Oct 1, 2024
Comment on lines
82
to
86
| pushToDataLayer('internship_prijava'); | ||
|
|
||
| try { | ||
| createIntern.mutate(internToSend); | ||
| } catch (err) { |
There was a problem hiding this comment.
Jeli bolje da se pushToDataLayer poziva nakon createIntern.mutate jer je Stipe reka nakon upisivanja u bazu? Ili možda čak najbolje ako radi na onSuccess callback od useMutate hooka usePostIntern?
| @@ -77,6 +78,9 @@ export const ApplicationFormPage = () => { | |||
| }, | |||
| }; | |||
|
|
|||
| initDataLayer(); | |||
There was a problem hiding this comment.
Da li je potrebno da se initDataLayer poziva na svaki submit? Možda je dovoljno samo na prvi render page-a?
|
Isprovao lokalno, save-a event u window.dataLayer na submit forme. Meni se cini ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stipine upute:
GTM za provjeru https://tagmanager.google.com/#/container/accounts/6001208776/containers/31420780/workspaces/16