Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added possibility to change text color and background color of the selected row #170

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

dundee
Copy link
Owner

@dundee dundee commented Sep 10, 2022

fixes #168

@coveralls
Copy link

coveralls commented Sep 10, 2022

Pull Request Test Coverage Report for Build 3029635846

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 34 of 37 (91.89%) changed or added relevant lines in 2 files are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.8%) to 96.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tui/tui.go 22 25 88.0%
Files with Coverage Reduction New Missed Lines %
report/export.go 1 94.41%
cmd/gdu/app/app.go 10 93.45%
tui/tui.go 14 89.53%
Totals Coverage Status
Change from base Build 3025439325: 0.8%
Covered Lines: 2220
Relevant Lines: 2290

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #170 (42c8b1b) into master (263f106) will decrease coverage by 0.23%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   94.73%   94.49%   -0.24%     
==========================================
  Files          27       27              
  Lines        2450     2471      +21     
==========================================
+ Hits         2321     2335      +14     
- Misses         93       99       +6     
- Partials       36       37       +1     
Impacted Files Coverage Δ
tui/tui.go 86.04% <71.42%> (-3.46%) ⬇️
cmd/gdu/app/app.go 91.22% <100.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dundee dundee force-pushed the dundee/feat/custom-style branch from bd6dd64 to bae19b7 Compare September 10, 2022 22:56
@dundee dundee force-pushed the dundee/feat/custom-style branch from bae19b7 to 42c8b1b Compare September 10, 2022 23:03
@dundee dundee merged commit fca8d07 into master Sep 10, 2022
@dundee dundee deleted the dundee/feat/custom-style branch September 10, 2022 23:09
@dundee dundee changed the title feat: added possibility to change color of the selected text feat: added possibility to change text color and background color of the selected row Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight color does not look great with certain terminal themes
2 participants