Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore mouse events when modal is opened #205

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

dundee
Copy link
Owner

@dundee dundee commented Feb 3, 2023

fixes #203

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4083025909

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 96.331%

Files with Coverage Reduction New Missed Lines %
report/export.go 5 92.02%
Totals Coverage Status
Change from base Build 4000790132: 0.8%
Covered Lines: 2442
Relevant Lines: 2535

💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 94.18% // Head: 93.94% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (4341b59) compared to base (10c8ae1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   94.18%   93.94%   -0.25%     
==========================================
  Files          29       29              
  Lines        2700     2707       +7     
==========================================
  Hits         2543     2543              
- Misses        120      125       +5     
- Partials       37       39       +2     
Impacted Files Coverage Δ
tui/mouse.go 100.00% <100.00%> (ø)
report/export.go 88.12% <0.00%> (-4.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dundee dundee merged commit 8bdce9a into master Feb 3, 2023
@dundee dundee deleted the dundee/fix/delete branch February 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling while deletion dialog is displayed results in deletion of the wrong file
2 participants