Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce fix to archive failed queries on run_sql call #110

Merged
merged 2 commits into from
Feb 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions dune_client/api/extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,16 @@ def run_sql(
Requires Plus subscription!
"""
query = self.create_query(name, query_sql, params, is_private)
results = self.run_query(
query=query.base, performance=performance, ping_frequency=ping_frequency
)
if archive_after:
self.archive_query(query.base.query_id)
try:
results = self.run_query(
query=query.base, performance=performance, ping_frequency=ping_frequency
)
if archive_after:
self.archive_query(query.base.query_id)
except QueryFailed as exc:
if archive_after:
self.archive_query(query.base.query_id)
raise exc
antonio-mendes marked this conversation as resolved.
Show resolved Hide resolved
return results

######################
Expand Down
Loading