refactor: implement a maximum upperbound on parallel http requests to… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msf
force-pushed
the
bounded-jsonrpc-concurrency
branch
3 times, most recently
from
685f2b0
to
82794c1
Compare
adammilnesmith
approved these changes
Jul 23, 2024
msf
force-pushed
the
bounded-jsonrpc-concurrency
branch
2 times, most recently
from
6f0d4ff
to
ccbd98b
Compare
… the RPC node Currently we allow defining RPCConcurrency, but that is in reality the BLOCK CONCURRENCY, the number of blocks we fetch in parallel. for OP-Stack EVMs, we issue, for each block, in parallel, 3 RPC requests to the RPC Node. So, the real concurrency is something like: 3 * (RPCConcurrency + DLQRPCConcurrency) This patch enforces a maximum concurrency by using on rpcClient an internal workerPool. This uses the github.com/panjf2000/ants/v2 library Now the maximum total RPC concurrency is defined as 4 x RPCConcurrency
msf
force-pushed
the
bounded-jsonrpc-concurrency
branch
from
ccbd98b
to
d913247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the RPC node
Currently we allow defining RPCConcurrency, but that is in reality the BLOCK CONCURRENCY, the number of blocks we fetch in parallel.
for OP-Stack EVMs, we issue, for each block, in parallel, 3 RPC requests to the RPC Node.
So, the real concurrency is something like:
3 * (RPCConcurrency + DLQRPCConcurrency)
This patch enforces a maximum concurrency by using on rpcClient an internal workerPool.
This uses the github.com/panjf2000/ants/v2 library
Now the maximum total RPC concurrency is defined as 4 x RPCConcurrency