Skip to content

Commit

Permalink
fix aggregators in nft.trades (#5853)
Browse files Browse the repository at this point in the history
* fix aggregators in nft.trades

* fix duplicates

* syntax
  • Loading branch information
0xRobin authored Apr 30, 2024
1 parent 19ed942 commit d4bd1bb
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions macros/models/_sector/nft/enrich_nft_trades.sql
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,9 @@ SELECT
case when base.price_raw > uint256 '0' then cast(100*base.platform_fee_amount_raw/base.price_raw as double) else double '0' end as platform_fee_percentage,
case when base.price_raw > uint256 '0' then cast(100*base.royalty_fee_amount_raw/base.price_raw as double) else double '0' end as royalty_fee_percentage,
coalesce(agg1.contract_address,agg2.contract_address) as aggregator_address,
{% if aggregator_markers != null %}
CASE WHEN coalesce(agg_mark.aggregator_name, agg1.name, agg2.name)='Gem' AND base.block_number >= 16971894 THEN 'OpenSea Pro' -- 16971894 is the first block of 2023-04-04 which is when Gem rebranded to OpenSea Pro
ELSE coalesce(agg_mark.aggregator_name, agg1.name, agg2.name)
END as aggregator_name
{% else %}
coalesce(agg1.name,agg2.name) as aggregator_name
{% endif %}
FROM {{base_trades}} base
LEFT JOIN {{ref('tokens_nft')}} nft
ON nft.blockchain = base.blockchain
Expand All @@ -122,9 +118,9 @@ LEFT JOIN {{ ref('nft_aggregators') }} agg1
AND (base.buyer = agg1.contract_address
OR base.seller = agg1.contract_address)
LEFT JOIN {{ ref('nft_aggregators') }} agg2
ON agg1.contract_address is null -- only match if agg1 produces no matches, this prevents duplicates
ON agg1.contract_address is null -- this prevents duplicates
AND agg2.blockchain = base.blockchain
AND tx_to = agg2.contract_address
AND base.tx_to = agg2.contract_address
LEFT JOIN {{ ref('nft_ethereum_aggregators_markers') }} agg_mark
ON bytearray_starts_with(bytearray_reverse(base.tx_data_marker), bytearray_reverse(agg_mark.hash_marker)) -- eq to end_with()

Expand Down

0 comments on commit d4bd1bb

Please sign in to comment.