-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Element to NFT aggregator list on Ethereum, BNB, Avalanche & Polygon for v2 #1406
Add Element to NFT aggregator list on Ethereum, BNB, Avalanche & Polygon for v2 #1406
Conversation
…Avalanche & Polygon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hildobby these files look good -- just double checking with @soispoke that this fits how he envisioned expanding aggregator metadata models
can you also add updates to the following:
- alter_table_properties macro -- add the views similar to ethereum version, also the 'run query' at bottom
- dbt_project yaml file -- add new file directories under nft block similar to ethereum, ensure schema name is as intended
Just added all of those, let me know if it's missing anything else! |
in the alter table file, can you also add to the block at the bottom? that'll actually run the commands (similar to this: {% do run_query(nft_ethereum_aggregators) %}) |
Done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick updates. lgtm. i'll let @soispoke give a final glance when he's ready in his time zone, but i'll approve on my side
Just had a look, looks good to me @jeff-dude ! |
Brief comments on the purpose of your changes:
Added Element NFT Marketplace to the list of NFT aggregators on Ethereum, BNB, Avalanche & Polygon.
For Dune Engine V2
I've checked that:
lowercase_snake_cased
When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.