Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gnosis ERC-20s and NFTs #1469

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add Gnosis ERC-20s and NFTs #1469

merged 1 commit into from
Aug 31, 2022

Conversation

hildobby
Copy link
Collaborator

Brief comments on the purpose of your changes:

Asked. in Gnosis's discord and was sent this list: https://plik.root.gg/file/6UzimdVX1j66mbk6/HatYe7581OJapZUy/tokens.csv
It's exclusively Gnosis tokens. After some Python work I converted the list into those two with the required SQL syntax.

For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

@soispoke
Copy link
Contributor

LGTM, thansk @hildobby ! I'm starting to think we should build a macro tokens.nft spell with all blockchains, wdyt ?

@soispoke soispoke self-requested a review August 31, 2022 06:02
@soispoke soispoke merged commit 425ec00 into duneanalytics:main Aug 31, 2022
soispoke added a commit that referenced this pull request Aug 31, 2022
@samisbakedham
Copy link

Asked. in Gnosis's discord and was sent this list: https://plik.root.gg/file/6UzimdVX1j66mbk6/HatYe7581OJapZUy/tokens.csv It's exclusively Gnosis tokens. After some Python work I converted the list into those two with the required SQL syntax.

I like that idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants