Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Add missing tokens #1477

Merged
merged 2 commits into from
Sep 5, 2022
Merged

[Easy] Add missing tokens #1477

merged 2 commits into from
Sep 5, 2022

Conversation

gentrexha
Copy link
Contributor

Usual token update taken from missing tokens query:

https://dune.com/queries/236085

DuneV2 is still showing a lot of missing tokens that have already been added:

https://dune.com/queries/984709

@@ -6588,4 +6588,36 @@ FROM (VALUES
('0x06d5ca7c9accd15a87d4993a421b7e702bdbab20', 'X7m105', 18),
('0x9e980d7bdab85f0d58b3d5823a24d84879451ab4', 'PLSS', 18),
('0x79a06acb8bdd138beeecce0f1605971f3ac7c09b', '$LSVR', 18)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ensure a comma here before your new lines

@jeff-dude
Copy link
Member

Usual token update taken from missing tokens query:

https://dune.com/queries/236085

DuneV2 is still showing a lot of missing tokens that have already been added:

https://dune.com/queries/984709

we are still working on a solution for quicker deployment for tokens to v2 engine, but they should be refreshed soon in the db

fyi @soispoke

@gentrexha gentrexha requested a review from jeff-dude September 5, 2022 08:36
Copy link
Contributor

@soispoke soispoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jeff-dude and @gentrexha

@soispoke soispoke dismissed jeff-dude’s stale review September 5, 2022 10:34

comma was added

@soispoke soispoke merged commit d8e31fd into duneanalytics:main Sep 5, 2022
@gentrexha gentrexha deleted the missing-tokens branch September 14, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants