Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OpenSea's Buy Now with Buy for consistency with other marketplaces #1496

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Replace OpenSea's Buy Now with Buy for consistency with other marketplaces #1496

merged 1 commit into from
Sep 5, 2022

Conversation

hildobby
Copy link
Collaborator

@hildobby hildobby commented Sep 4, 2022

Brief comments on the purpose of your changes:

Replacing Seaport's abstraction's "Buy Now" with "Buy".

For Dune Engine V2
I've checked that:
General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if adding a new model, I edited the alter table macro to display new database object (table or view) in UI explorer
  • if adding a new materialized table, I edited the optimize table macro

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@soispoke
Copy link
Contributor

soispoke commented Sep 5, 2022

LGTM, tagging @sohwak for visibility

Copy link
Contributor

@soispoke soispoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hildobby !

@soispoke soispoke merged commit 5b5315d into duneanalytics:main Sep 5, 2022
@sohwak
Copy link
Contributor

sohwak commented Sep 5, 2022

Hi. Thanks for letting me know.

I agree that unifying the code values. in nft.trades on Dune v1, category with the same meaning named slightly differently, so it was inconvenient. The code values for NFT may vary by project, but most of them could be named as buy and offer accepted.

for Seaport on Dune v2, we didn't use the code value as a direct condition, so it would be good time to change it.

@soispoke
Copy link
Contributor

soispoke commented Sep 5, 2022

Thanks for your input @sohwak !

@sohwak
Copy link
Contributor

sohwak commented Sep 5, 2022

I also checked the files changed, and confirmed all Buy Now are covered. Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants