-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring erc20
and nft
on par in V2
#1511
Conversation
Workflow run id 2997439347 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thansk @chuxinh for this submission!
,('0x62bb4fc73094c83b5e952c2180b23fa7054954c4','PTaOptUSDC', 6) | ||
,('0x66e8617d1df7ab523a316a6c01d16aa5bed93681','SHACK', 18) | ||
,('0x00a35fd824c717879bf370e70ac6868b95870dfb','IB', 18) | ||
,('0xf899e3909b4492859d44260e1de41a9e663e70f5','RADIO', 18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove one of these two lines to avoid duplicates @chuxinh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @chuxinh, lgtm !
Workflow run id 2997950379 approved. |
,('0x62bb4fc73094c83b5e952c2180b23fa7054954c4','PTaOptUSDC', 6) | ||
,('0x66e8617d1df7ab523a316a6c01d16aa5bed93681','SHACK', 18) | ||
,('0x00a35fd824c717879bf370e70ac6868b95870dfb','IB', 18) | ||
,('0xf899e3909b4492859d44260e1de41a9e663e70f5','RADIO', 18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @chuxinh, lgtm !
Add additional
erc20
andnft
tokens that exist in V1 to V2For Dune Engine V2
I've checked that:
General checks:
lowercase_snake_cased
Join logic:
Incremental logic: