Add Pancakeswap NFT Events #2255

thb030100 · 2022-12-07T16:07:50Z

Brief comments on the purpose of your changes:

For Dune Engine V2

I've checked that:

General checks:

I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
if adding a new model, I added a test

dune-eng · 2022-12-07T16:08:23Z

Workflow run id 3640654290 approved.

dune-eng · 2022-12-07T16:08:24Z

Workflow run id 3640654291 approved.

dune-eng · 2022-12-08T02:38:53Z

Workflow run id 3644726959 approved.

dune-eng · 2022-12-08T02:38:53Z

Workflow run id 3644726961 approved.

dune-eng · 2022-12-08T03:36:27Z

Workflow run id 3645025551 approved.

dune-eng · 2022-12-08T03:36:28Z

Workflow run id 3645025544 approved.

0xRobin

Thanks for the PR, I've added some minor suggestions.
Main thing is we'd like to see a seed file with a couple example trades in them to setup a test.
You can add that under seeds/pancakeswap/bnb/pancakeswap_nft_trades_samples.csv.
Then you'll also have to update the dbt_project.yml file to include the seed.

Let me know if you have questions.

models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql

models/pancakeswap/bnb/pancakeswap_bnb_schema.yml

models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql

dune-eng · 2022-12-08T16:04:56Z

Workflow run id 3649973300 approved.

dune-eng · 2022-12-08T16:04:56Z

Workflow run id 3649973301 approved.

dune-eng · 2022-12-08T16:07:24Z

Workflow run id 3649994929 approved.

dune-eng · 2022-12-08T16:07:25Z

Workflow run id 3649994928 approved.

dune-eng · 2022-12-08T16:07:35Z

Workflow run id 3649996711 approved.

dune-eng · 2022-12-08T16:07:37Z

Workflow run id 3649996707 approved.

dune-eng · 2022-12-08T16:10:13Z

Workflow run id 3650017945 approved.

dune-eng · 2022-12-08T16:10:15Z

Workflow run id 3650017939 approved.

dune-eng · 2022-12-08T17:04:35Z

Workflow run id 3650433225 approved.

dune-eng · 2022-12-08T17:04:35Z

Workflow run id 3650433215 approved.

thb030100 · 2022-12-08T17:05:22Z

Thanks for the PR, I've added some minor suggestions. Main thing is we'd like to see a seed file with a couple example trades in them to setup a test. You can add that under seeds/pancakeswap/bnb/pancakeswap_nft_trades_samples.csv. Then you'll also have to update the dbt_project.yml file to include the seed.

Let me know if you have questions.

I have added the seed file, can you check! Thanks

thb030100 · 2022-12-20T18:05:17Z

@thb030100 looks like tests are passing! 👏
I will add some changes for consistency and integrate this model with the general nft.trades one.
After that we are good to merge this!
Thanks for the contribution, the first one is always the hardest. 😄

Thank you! I am also adding a few more marketplaces. Will follow this PR as an instruction!

dune-eng · 2022-12-21T03:37:53Z

Workflow run id 3746198852 approved.

dune-eng · 2022-12-21T03:37:53Z

Workflow run id 3746198851 approved.

…main

dot2dotseurat · 2022-12-21T14:57:01Z

Sorry, switching this to do not merge for the time being. I'm checking if this will work on DuneSQL and it will cause nft.trades to be unqueryable. I need to look more closely to see why.

@thb030100 thank you for making this contribution, we'll get it merged and welcome more contributions. Excellent first contribution by the way!

dot2dotseurat · 2022-12-21T15:02:26Z

@belen-pruvost does this type of error look familiar to you? This is from the CI created table tested on DuneSQL. I'm not familiar with Error getting snapshot.

Error: Line 1:15: Failed analyzing stored view 'delta_prod.test_schema.git_653e5544_pancakeswap_bnb_nft_trades': Error getting snapshot for test_schema.git_653e5544_pancakeswap_bnb_nft_events at line 1, position 15.

belen-pruvost · 2022-12-21T15:09:33Z

Hey @dot2dotseurat! Yes, the underlying issue here is that test_schema.git_653e5544_pancakeswap_bnb_nft_events has a DBFS location instead of an S3 one (see here). Ideally the CI that creates the test schema would need to use something like what we discussed here.

dot2dotseurat · 2022-12-21T19:04:23Z

@belen-pruvost ah, makes sense. thanks for checking.

We can probably go ahead and merge this then.

soispoke

lgtm

* add seed in yml file * Add Pancakeswap NFT V1 to nft trades * delete tofu * Adjust * update * update LOGIC * initial commit * update * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * add test * add * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * delete liquidifty * add test file * . * update * fix unique ID * update sample file * change pancakeswap seed schema * temporary comment trade section * reinstate test and correct columns * change sample file * change seed file * add pancakeswap to nft trades * add royalty info * fix currency_symbol * guard fee logic * cast null as string * remove double column Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> Co-authored-by: 0xRob <0xRobin5@gmail.com>

* fix perp contract * update token generations & move files * mod aave sources * update erc20 schema * mod atoken sources * fix indent * aave sources alignment * update aave schema again * granary sources update * more schema updates * update ovm_optimism schema * mod aave schema * whoops - fix commas * fix commas * take - out of descriptions * fixes * expose OP erc20s as a separate detailed list * map op back to erc20 tokens * add standard to nft for op * update dbt project * add sided * Update contracts_optimism_contract_creator_address_list.sql * small * typo * Update tokens_optimism_schema.yml * adds * add dependency on snapshot * Fix dbt_project.yml * Update tokens_optimism_nft.sql * remove generated tokens for now * initialize without circular dependencies * update prices * update btc.b * forget snapshot * remove deps * aave chain insert * fix aave for loop * fix atokens select * simplify * alias * fix gran * fix gran note - granary initialized events are missing * comment out descriptor * erc20 schema * fix * Update tokens_optimism_erc20.sql * price dupe * update lists * nft list * fix unique nft * add attestation override * add mm swaps * Update tokens_optimism_nft.sql * add gysr * add nft * add erc20 * quix <> rh contract * stick * add type on atokens * add woofi * adds * Reformat aave_v3_tokens for compatibility * Fix typo * Add uniqueness test * Remove schema in config block * Reformat granary_tokens and compatibility for Trino * add token to prices * adds * add creator and update nft name * revert OaycNFT renaming * Apply CAST() to number_of_items and amount_raw * fix tofu_bnb schema * Add CAST() to fields * fix fee convention * Remove hardcoded fields from nft_trades * convert to hours (#2399) * [Easy] [Label] Implement trader platforms label (#2394) * Implemented trader platforms label * Fixed errors in spell * Added forgotten group by * Fixed columns selection * Added ordering and keeping of order for label * Fixed error in brackets * Added missing block_time column * Added time to keep order * [easy] new tokens (#2414) * Adding Aave V3 assets to tokens_avalanche_c_erc20.sql and tokens_polygon_erc20.sql (#2410) * add AAVE, EURS to arbitrum_erc20.sql * adding remaining aave v3 assets to erc20 * [CoW Protocol] Add Referral Mapping (#2377) * add referral table * remove duplicate anchor * remove unused subquery * Add Pancakeswap NFT Events (#2255) * add seed in yml file * Add Pancakeswap NFT V1 to nft trades * delete tofu * Adjust * update * update LOGIC * initial commit * update * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * add test * add * Update models/pancakeswap/bnb/pancakeswap_bnb_nft_market_v1_event.sql Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> * delete liquidifty * add test file * . * update * fix unique ID * update sample file * change pancakeswap seed schema * temporary comment trade section * reinstate test and correct columns * change sample file * change seed file * add pancakeswap to nft trades * add royalty info * fix currency_symbol * guard fee logic * cast null as string * remove double column Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> Co-authored-by: 0xRob <0xRobin5@gmail.com> * Migrate Balancer `vebal_slopes` abstraction (#2179) * Add balancer_vebal_slopes to schema yml file * Add veBAL related sources to sources yml file * Add balancer_vebal_slopes spell * Reorder sources * Change casting syntax * Rename datetime field from schema .yml file * Add incremental logic to vebal_slopes spell * Update models/balancer/ethereum/balancer_vebal_slopes.sql Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Update models/balancer/ethereum/balancer_vebal_slopes.sql Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Update models/balancer/ethereum/balancer_ethereum_schema.yml Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Update models/balancer/ethereum/balancer_vebal_slopes.sql Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Replace block_time unique key for block_number * Update models/balancer/ethereum/balancer_ethereum_schema.yml Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Update models/balancer/ethereum/balancer_vebal_slopes.sql Co-authored-by: Huang Geyang <Sukebeta@outlook.com> * Replace block_date for block_number in uniqueness test * Rewrite group by in full column names * Fix unmatched columns in schema.yml * add descriptions to vebal_slopes columns Co-authored-by: Huang Geyang <Sukebeta@outlook.com> Co-authored-by: Fábio Mendes <ms.fabiomendes@gmail.com> * Update cow_protocol_ethereum_referrals.sql (#2423) * Fix Source Chain ID/Name Hop Optimism (#2313) * Update hop_protocol_flows.sql * Revert "Update hop_protocol_flows.sql" This reverts commit be30148. * Update hop_protocol_optimism_flows.sql * Add BSC Dodo trades to dex.trades (#2157) * dodo-bnb-trades-real * add seed tests * seed value typo * remove depracated test * Modify dodo_bnb to aligh with dodo_eth in project.yml * combine cross-chain bnb & ethereum trades * correct ethereum dodo trades * downgrade 'dbt_utils' * Change back dbt_utils version to 0.9.2 * final tweaks * force failure * Remove extra line * correct seed file * restore deleted prices * minor formatting * cleanup dbt_project with latest standard * add freshness check Co-authored-by: Huang Geyang <Sukebeta@outlook.com> Co-authored-by: jeff-dude <jeff@dune.xyz> * script to find sources missing checks (#2401) * script to find sources missing checks + new freshness checks * T-22136: Missing ERC20 tokens (#2425) * add A LOT of missing tokens * sort + indentation * escape backtick * add missing comma * remove last comma * remove duplicate * add trim to symbol * remove trim, see if test pass * fixed trim Co-authored-by: jeff-dude <jeff@dune.xyz> * Update pull_request_template.md (#2429) * Update README.md (#2411) * T-23065 - optimism transfers: update value filter for string datatype (#2426) * update value filter for string datatype * directory cleanup * Seaport ethereum patch (#2419) * unifying seaport source * keep unique_trade_id for opensea.trades for nft.trades compatability * merge schema file * cast amount to decimal(38,0) * add test seeds * update schema.yml * Fix: minor typos (#2424) * Fix: minor typos Fix: minor typos * Fix: minor typo Fix: minor typo * Fix: minor typo Fix: minor typo * Fix: minor typo Fix: minor typo * [Quick] Updates to metadata files (#2421) * add new metadata * fix duplicate error Co-authored-by: cat <cat377550@gmail.com> * Added alphasharks.io as an aggregator (#2417) * Fix aave liquidation call (#2432) * FIX: cast to varchar in opensea_v3 trades (#2433) * cast to varchar in concat in view * define varchar length' * use batch api calls for price checker (#2431) * use batch api calls for price checker * Update dodo_ethereum_trades & add dodo_bnb_trades & split them to aggregator and pools (#2169) * update dodo_ethereum_trades && add dodo_bnb_trades * split dodo_trades to pools & aggregator on Ethereum and BNBChain * label different dodoV2 pools * fix schema & sql * add dodo_proxies on Ethereum * Modify dodo_bnb_trades to incremental view * Apply check_dex_seed and modify dodo_eth_trades to incremental view * Add DODO bnb trade seeds * Apply check_dex_seed to DODO bnb trades model * update dex_trade_seeds * fix * Add DODO bnb in project.yml * remove gitkeep in dodo * Update models/dodo/bnb/dodo_pools_bnb_trades.sql * Update check_dex_seed in dodo_ethereum_schema.yml * fix dodo_ethereum_schema * Remove schema in the config blocks * Add dodo_trades files by scoffie * add dppOracle & dppAdvanced to dodo_bnb * fix * update dbt_project on dodo * fix dodo_bnb_sources.yml * move cast to base model * update dex.trades seeds on DODO_BNBChain * final formatting & cleanup expose spell macro Co-authored-by: Huang Geyang <Sukebeta@outlook.com> Co-authored-by: jeff-dude <jeff@dune.xyz> * [CoW] Fix Fee USD Calculation (#2422) * use most natural form of fee computation when possible * add comment about imprecision * Fix failing tests (#2396) * trigger test * enable test in CI * defer in test * fix aragon * fix native token test * fix native mints unique id * fix nft trader labels * union all in nft labels * union all for performance * trigger wash_trades full refresh * fix cow protocol distinct labels * revert null wallet_address fix Co-authored-by: soispoke <66172107+soispoke@users.noreply.github.com> * Add ETH Transfers to L1 (#2440) * add eth transfers and small type fixes in op eth transfers * comment update * update schema * update transfer id * add tx to and from * add tx_to and tx_from * nit remove spaces Co-authored-by: soispoke <66172107+soispoke@users.noreply.github.com> * Token checker tweaks (#2437) * allow for case insensitive token symbol matching * adapt token checker error/warns * check for warning in test instead of error * Allow for local compile of incremental models. (#2403) * base is_incremental * add force-incremental variable * clean up dbt_project values * add version schema name * rename ovm directory * naming standards * keep optimism erc20 view name Co-authored-by: Huang Geyang <Sukebeta@outlook.com> Co-authored-by: 0xRob <0xRobin5@gmail.com> Co-authored-by: Belén Pruvost <belen@dune.com> Co-authored-by: Meghan Heintz <meghan@dune.com> Co-authored-by: Gent Rexha <gent@cow.fi> Co-authored-by: josojo <josojo@hotmail.de> Co-authored-by: mc <mattcole1093@gmail.com> Co-authored-by: Benjamin Smith <bh2smith@users.noreply.github.com> Co-authored-by: Harry <81097471+thb030100@users.noreply.github.com> Co-authored-by: 0xRob <83790096+0xRobin@users.noreply.github.com> Co-authored-by: Victor Stefenon <victorstefenon0@gmail.com> Co-authored-by: Fábio Mendes <ms.fabiomendes@gmail.com> Co-authored-by: soispoke <66172107+soispoke@users.noreply.github.com> Co-authored-by: Levis Kithinji <64379631+LeviScoffie@users.noreply.github.com> Co-authored-by: jeff-dude <jeff@dune.xyz> Co-authored-by: jeff-dude <102681548+jeff-dude@users.noreply.github.com> Co-authored-by: sohwak <59173567+sohwak@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: catherine-2 <95732099+catherine-2@users.noreply.github.com> Co-authored-by: cat <cat377550@gmail.com> Co-authored-by: Garv Maggu <17963209+GarvMaggu@users.noreply.github.com> Co-authored-by: Dias <dsalv@users.noreply.github.com> Co-authored-by: owen05 <owen05@users.noreply.github.com>

thb030100 changed the title ~~Add Pancakeswap NFT Trade~~ Add Pancakeswap NFT Events Dec 8, 2022

0xRobin self-assigned this Dec 8, 2022

0xRobin requested changes Dec 8, 2022

View reviewed changes

0xRobin added the WIP work in progress label Dec 8, 2022

thb030100 closed this Dec 9, 2022

thb030100 force-pushed the main branch from b8abd79 to 537ead7 Compare December 9, 2022 02:28

thb030100 added 7 commits December 9, 2022 09:29

add seed in yml file

7c1faee

Add Pancakeswap NFT V1 to nft trades

b070a76

delete tofu

9253811

Adjust

696da6a

update

cbc1215

update LOGIC

51898e0

initial commit

e988e17

0xRobin added in review Assignee is currently reviewing the PR and removed WIP work in progress labels Dec 20, 2022

0xRobin added 4 commits December 20, 2022 15:35

add royalty info

2ecb962

fix currency_symbol

a6b360a

guard fee logic

7df4c29

cast null as string

f4b0cd4

0xRobin approved these changes Dec 20, 2022

View reviewed changes

0xRobin added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Dec 20, 2022

Merge branch 'duneanalytics:main' into main

e2d140f

0xRobin added 2 commits December 21, 2022 08:43

remove double column

33a3cf2

Merge branch 'main' of github.com:thb030100/spellbook into thb030100/…

8b18ce8

…main

dot2dotseurat added do not merge and removed ready-for-merging labels Dec 21, 2022

0xRobin added ready-for-merging and removed do not merge labels Dec 22, 2022

Merge branch 'main' into main

f0b3b0a

soispoke self-requested a review January 3, 2023 15:33

soispoke approved these changes Jan 4, 2023

View reviewed changes

soispoke merged commit 604be8a into duneanalytics:main Jan 4, 2023

soispoke self-assigned this Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Pancakeswap NFT Events #2255

Add Pancakeswap NFT Events #2255

thb030100 commented Dec 7, 2022 •

edited by 0xRobin

Loading

dune-eng commented Dec 7, 2022

dune-eng commented Dec 7, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

0xRobin left a comment

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

thb030100 commented Dec 8, 2022

thb030100 commented Dec 20, 2022

dune-eng commented Dec 21, 2022

dune-eng commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

belen-pruvost commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

soispoke left a comment

Add Pancakeswap NFT Events #2255

Add Pancakeswap NFT Events #2255

Conversation

thb030100 commented Dec 7, 2022 • edited by 0xRobin Loading

General checks:

dune-eng commented Dec 7, 2022

dune-eng commented Dec 7, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

0xRobin left a comment

Choose a reason for hiding this comment

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

dune-eng commented Dec 8, 2022

thb030100 commented Dec 8, 2022

thb030100 commented Dec 20, 2022

dune-eng commented Dec 21, 2022

dune-eng commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

belen-pruvost commented Dec 21, 2022

dot2dotseurat commented Dec 21, 2022

soispoke left a comment

Choose a reason for hiding this comment

thb030100 commented Dec 7, 2022 •

edited by 0xRobin

Loading