-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big NFT sector cleanup! #3253
Big NFT sector cleanup! #3253
Conversation
Here's a comparison between the production tables and the tables in the PR to confirm I've not forgotten any specific platform. |
✔️ CI checks are actually passing. |
✔️ checks are passing expect dunesql checks on big models due to java heap space. |
can you fix merge conflicts and let CI run again? i gave a passthrough of the code, i think i follow the general flow:
|
@jeff-dude |
b400eed
to
de39fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets push this and only this through, let it ride in prod
edit: canceled the ci test
awesome, I'll monitor the next hourly run 👍 |
This PR cleans up the NFT trades sub sector spells.
Baiscally it reduces every platform specific models to only the "events" models, removing the "trades", "fees", "burns", "mints" models which should all just be a view on the "events" model.
We had some inconsistencies with platforms only implementing some of these tables which resulted in platforms being present in events but not in trades or fees,..
New setup:
nft_events
modelnft_fees
,nft_burns
and 'nft_mints' are views on top ofnft_events
This cleanup will also help a lot during the ongoing NFT restructuring migration.
There's a small impact on users as models like
blur.fees
don't exist anymore after this is merged and they should useblur.events
or the overallnft.fees
model.Part 2:
expose_spel
from those marketplace events models<marketplace>.trades
view, which is the only marketplace specific view that will get exposed on the App