Source rowcount generic test #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRobin
added
ready-for-review
jeff-dude
approved these changes
May 4, 2023
jeff-dude
removed
the
ready-for-review
Hosuke
reviewed
May 4, 2023
Comment on lines
+79
to
+84
| - equal_rowcount_with_sources: | ||
| evt_sources: | ||
| - source('foundation_ethereum','market_evt_ReserveAuctionFinalized') | ||
| - source('foundation_ethereum','market_evt_BuyPriceAccepted') | ||
| - source('foundation_ethereum','market_evt_OfferAccepted') | ||
| - source('foundation_ethereum','market_evt_PrivateSaleFinalized') |
There was a problem hiding this comment.
I see, so this part can test the sum of events from multiple event sources.
Hosuke
reviewed
May 4, 2023
Comment on lines
+20
to
+26
| select count_a, count_b, (count_a - count_b) as diff_count | ||
| from model_count | ||
| full outer join sources_count | ||
| on 1=1 | ||
| ) | ||
|
|
||
| select * from unit_test where diff_count > 0 |
There was a problem hiding this comment.
Do we need to write abs(count_a - count_b) as diff_count?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a generic rowcount test to compare with a list of event sources